fossas / fossa-cli

Fast, portable and reliable dependency analysis for any codebase. Supports license & vulnerability scanning for large monoliths. Language-agnostic; integrates with 20+ build systems.
https://fossa.com
Other
1.29k stars 173 forks source link

Convert MSB errors to warnings #1469

Closed jssblck closed 2 months ago

jssblck commented 2 months ago

Overview

When a user has configured a project to be linked to a binary via MSB, and then they lose access to the project (either because a different user is running the scan, or the project has been deleted, or some other reason) the scan currently fails:

Failed to resolve dependencies for the following FOSSA projects:
    custom+19518/some-project$some-revision

You may not have access to the projects, or they may not exist (see the warnings below for details).
If desired you can use --experimental-skip-vsi-graph to skip resolving the dependencies of these projects.

The user then has to use --experimental-skip-vsi-graph to resolve this issue. This PR alters the error to be a warning instead of a fatal error.

The --experimental-skip-vsi-graph flag is still there so that users using it don't encounter problems, but it is now largely irrelevant (it would only suppress this warning).

Acceptance criteria

This error is now a warning.

Testing plan

This is proven in the type system, I don't believe it requires testing. No tests currently exist for this functionality, so I didn't alter any existing tests.

Risks

No risk.

Metrics

None

References

https://fossa.atlassian.net/browse/ANE-2005

Checklist