fossasia / 2016.fossasia.org

FOSSASIA Summit 2016 https://2016.fossasia.org
1.57k stars 117 forks source link

Update index.html (Added missing speaker's list 8+) #147

Closed yashk0thari closed 6 years ago

yashk0thari commented 6 years ago

138 I've added missing speaker's list (8)

yashk0thari commented 6 years ago

Is it ohk now ??

yashk0thari commented 6 years ago

if not, could you please describe what changes i have to do... sorry for the inconvenience...

anshumanv commented 6 years ago

The #140 that you wrote in the PR description should actually be an issue number corresponding to this PR.

yashk0thari commented 6 years ago

ohkk, sorry for that. i thought that was the issue number only, i've made the change. looks good ??

yashk0thari commented 6 years ago

How much longer ?? is there anything left to do ??

akshatnitd commented 6 years ago

@Beta-King Make sure you complete the PR template and submit it, instead of deleting it.

Provide a deployment link, so that we can test it and then merge

yashk0thari commented 6 years ago

kk, guys i've submitted a task in GCI for review and the pull request has been merged, but hasnt been approved in the GCI task menu; could you plz do that, it this one >> Website: FOSSASIA Summit 2017: Add missing Profile Links of Speakers and Team ( FOSSASIA )

Thanks :D

yashk0thari commented 6 years ago

and gitter is not working, so this is only way i could communicate

yashk0thari commented 6 years ago

Could you approve the task??

yashk0thari commented 6 years ago

https://beta-king.github.io/Beta-King.2016.fossasia.org/ --> preview link :D

akshatnitd commented 6 years ago

@Beta-King Please squash the commits

yashk0thari commented 6 years ago

ohk

yashk0thari commented 6 years ago

im having problems merging... im opening another PR