fossasia / 2019.fossasia.org

FOSSASIA Summit 2019 https://2019.fossasia.org

1.44k stars 138 forks source link

worked on displaced menu button and space between buttons and social icons in footer #109

Open Vineet-Sharma29 opened 5 years ago

Vineet-Sharma29 commented 5 years ago

[x] Included a Preview link and screenshot showing after and before the changes.
[x] Included a description of the change below.
[x] Squashed the commits.

Changes done in this Pull Request

Preview Link
Fixes #102 #113 #119

Description / Changes

Before the change in code, the menu button was displaced. Also, there was margin problem between two buttons and social icons.
This was because of unresponsive 'Schedule Roaster' table and 'UNESCO_SDG.png' image. Margin issue was fixed by adding 'footer-icon' class in section 17 and modifying 'btn' class in theme-lava.css
Updated schedule roster
In this PR, above bugs are fully solved
preview link : https://vineet-sharma29.github.io/2019.fossasia.org/

Screenshots if any:

Before:

before

spaceing-before spacing-before-2 spacing-before-3

After:

after spacing-after spacing-after-2 spacing-after-3

after119

kushthedude commented 5 years ago

Can you provide a preview link?

kushthedude commented 5 years ago

@Vineet-Sharma29 Please dont change any other thing except which is related to your issue

mohitm15 commented 5 years ago

@Vineet-sharma29 Should I take this issue??

Vineet-Sharma29 commented 5 years ago

@mohitm15 I have resolved the issue through this PR.

mohitm15 commented 5 years ago

Okay no problem ,if not merged then I will take this

On Sat 9 Mar, 2019, 9:58 PM Vineet Sharma, notifications@github.com wrote:

@mohitm15 https://github.com/mohitm15 I have resolved the issue through this PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/2019.fossasia.org/pull/109#issuecomment-471197849, or mute the thread https://github.com/notifications/unsubscribe-auth/Ah5JcUXi8XqleuuStURi9xT_Qv-kEpmQks5vU-EtgaJpZM4bkZGz .

mariobehling commented 5 years ago

Please don't add more CSS into the html file. Actually we got some css in just to solve some issues temporarily and now this practice seems to become the standard. Please don't do this.

Vineet-Sharma29 commented 5 years ago

Okay @mariobehling Sir

kushthedude commented 5 years ago

@Vineet-Sharma29 any progress?

Vineet-Sharma29 commented 5 years ago

@kushthedude I have removed extra CSS class

garvitkhandelwal commented 5 years ago

Progress? @Vineet-Sharma29

mohitm15 commented 5 years ago

@garvitkhandelwal this website was made for fossasia summit which was held in March 2019. So now no one will be able to review your PR ..so try to switch over to any other working project and contribute 😃

Sent from my VIBE K6 Power using FastHub

garvitkhandelwal commented 5 years ago

Sorry my bad @mohitm15