fossasia / 2019.fossasia.org

FOSSASIA Summit 2019 https://2019.fossasia.org

1.44k stars 138 forks source link

Adding speakers into featured list #110

Closed kushthedude closed 5 years ago

kushthedude commented 5 years ago

[ ] Included a Preview link and screenshot showing after and before the changes.
[x] Included a description of the change below.
[x] Squashed the commits.

Changes done in this Pull Request

Added all the speakers in the featured list.

Preview Link
Fixes #106

Description / Changes

Added all featured speakers from eventyay to 'index.html'. -Images of some speakers were not present in 'img/' , So i have added some images in 'img/'.

kushthedude commented 5 years ago

@mariobehling , Sir , Sorry for taking long but took a while to add the speakers , Ready for review. Preview Link: https://kushthedude.github.io/2019.fossasia.org/

mariobehling commented 5 years ago

Please do the following:

Only take the first sentence of the description/bio of speakers.
Ensure all images are showing up
Scale up images that are too small

-> check out your own deployment and identify issues.

kushthedude commented 5 years ago

@mariobehling , Sir, Since the pictures of some speakers are of less resolution if i will scale them up images will be pixelated and will look ugly on the page, If you say so we can remove the those speakers whose picture is not available in adequate quality ?

kushthedude commented 5 years ago

@mariobehling Sir , The commits you requested have been made , 1.) Scaled up images. 2.)Ensured all the images are being displayed on my machine 3.)Only took a sentence or a paragraph for speaker bio.

mariobehling commented 5 years ago

Preview link does not show the speakers added.

mariobehling commented 5 years ago

Only change the relevant areas in index.html! Don't change other parts.

kushthedude commented 5 years ago

I am sorry for the indentation created by my IDE. Will resolve it and update the preview link

kushthedude commented 5 years ago

Closing via #112