search

fossasia / 2019.fossasia.org

FOSSASIA Summit 2019 https://2019.fossasia.org
1.44k stars 138 forks source link

No margin between two buttons #113

Open Vineet-Sharma29 opened 5 years ago

Vineet-Sharma29 commented 5 years ago

Actual Behaviour No space between two buttons and icons in the footer in mobile

Expected Behaviour Their should be some margin between two buttons and icons in the footer

Steps to reproduce it View 'Ultimate Cloud Training Session' section and social icons of the footer in the mobile browser

Screenshots of the issue spaceing-before spacing-before-2 spacing-before-3

Would you like to work on the issue? I would like to work on this issue

punkstar25 commented 5 years ago

@Vineet-Sharma29 I would like to work on this issue . can u assign it to me??

Vineet-Sharma29 commented 5 years ago

@punkstar25 go for it

punkstar25 commented 5 years ago

is there any time limit for compete the task... i am asking this bcz i am new to open source and this is my first project...

Vineet-Sharma29 commented 5 years ago

@punkstar25 avoid adding extra css. The issue is simple it will not take time.

punkstar25 commented 5 years ago

ok.. i will give my best.

punkstar25 commented 5 years ago

sir, i think i find the bug ... we have to add this think in theme-lava.css a.btn { margin-top: 4px; margin-bottom: 4px; margin-right: 4px; } i am not sure but i think this would work

Vineet-Sharma29 commented 5 years ago

@punkstar25 send PR when you are sure

punkstar25 commented 5 years ago

@Vineet-Sharma29 , is my changes is correct...