fossasia / 2019.fossasia.org

FOSSASIA Summit 2019 https://2019.fossasia.org

1.44k stars 138 forks source link

Update mobile view #143

Open pranavkarthik10 opened 4 years ago

pranavkarthik10 commented 4 years ago

[x] Included a Preview link and screenshot showing after and before the changes.
[x] Included a description of the change below.
[x] Squashed the commits.

Changes done in this Pull Request

Preview Link
Fixes #118

Description / Changes

I updated the view using the overflow-x attribute for the body to hidden which allowed all overflow to be modified and changed to only fit the view.

Screenshots if any:

Before:

After:

pranavkarthik10 commented 4 years ago

@mariobehling Please review and merge! Thanks :)

Dishebh commented 4 years ago

@pranavkarthik10 pls have a look at the Schedule Roster section, hope it doesn't get affected / cut due to this. Thanks.

pranavkarthik10 commented 4 years ago

@Dishebh Thank you for letting me know! I have fixed it and simplified the code massively by converting the schedule roster section to an image. It still preserves quality in different devices.

pranavkarthik10 commented 4 years ago

@mariobehling Please review this! Thank you.

pranavkarthik10 commented 4 years ago

@mariobehling Please review and merge when you get a chance. Thanks!

pranavkarthik10 commented 4 years ago

@mariobehling May I know why, otherwise the schedule roster section is the only reason why the mobile view does not look good. There are other ways to make it responsive but it would not look as good as the desktop version.