search

fossasia / Connect-Me

Connect-Me with FOSSASIA Chrome Extension :rocket:
BSD 3-Clause "New" or "Revised" License
1.37k stars 78 forks source link

Enhancing `onclick()` buttons #3

Closed 0x48piraj closed 6 years ago

0x48piraj commented 6 years ago

Current State :

Click Bug

Expected Outcome :

Direct clicking should open the link in a new tab.

vaibhavsingh97 commented 6 years ago

Claiming

prshntsingh commented 6 years ago

@0x48piraj @vaibhavsingh97 Is this issue still open?I can't see the changes reflected in my local machine.I am new to open source please help.

0x48piraj commented 6 years ago

Clone and move to development branch, and then try to launch and test the application.

prshntsingh commented 6 years ago

@0x48piraj Can you please tell me how to move to development branch? I can see only one branch in my cloned repository and this repository.I am new to git please help.

Where can I communicate for doubts?Is there any chat channel dedicated to this project?

0x48piraj commented 6 years ago

Use FOSSASIA Gitter Channel - https://gitter.im/fossasia/fossasia

vaibhavsingh97 commented 6 years ago

As @0x48piraj Had deleted development branch so this bug is active again. @prshntsingh This is a beginner friendly bug so you can fix it

prshntsingh commented 6 years ago

okay @vaibhavsingh97 thank you!! :)

0x48piraj commented 6 years ago

As mariobehling has deleted development branch, the fix is missing again. @prshntsingh Just use target attr. in href to fix the bug. Ping - @vaibhavsingh97 :+1:

prshntsingh commented 6 years ago

Will do it @0x48piraj 🙂