search

fossasia / Connect-Me

Connect-Me with FOSSASIA Chrome Extension :rocket:
BSD 3-Clause "New" or "Revised" License
1.37k stars 78 forks source link

Adding an in-built Subscribe button #4

Open 0x48piraj opened 6 years ago

0x48piraj commented 6 years ago

Current State :

No such implementation yet.

Expected Outcome :

A Subscribe button to let users subscribe to FOSSASIA.

prshntsingh commented 6 years ago

@0x48piraj Can you please elaborate? By "subscribe to FOSSASIA" do you mean to subscribe to Fossasia's mail?

0x48piraj commented 6 years ago

Indeed. @prshntsingh 👍

prshntsingh commented 6 years ago

@0x48piraj Can I work on this issue?

0x48piraj commented 6 years ago

Absolutely. Start right away!

prshntsingh commented 6 years ago

Okay🙂

0x48piraj commented 6 years ago

Any Updates @prshntsingh ?

prshntsingh commented 6 years ago

@0x48piraj was busy with my institute exams.I will work on it this weekend.

0x48piraj commented 6 years ago

Updates @prshntsingh ?

prshntsingh commented 6 years ago

@0x48piraj sorry for late reply.Actually my institute exams are going on. I will do it as soon as it gets over.

Rishabh570 commented 6 years ago

@0x48piraj @prshntsingh I would like to add subscribe button. Can I work on this?

0x48piraj commented 6 years ago

Definitely! Go on!

Rishabh570 commented 6 years ago

@0x48piraj Actually I've added the subscribe button and it's working completely fine for chrome but transitions in firefox are broken, I don't know why (I'm using Jquery's fadeIn() and hide())...

Screenshot for Chrome

main-layout

subscribe-form

Screenshot for firefox

buggy

Should I first fix it for firefox then open a PR or just open a PR so that other people could help in it??

mohitsharma23 commented 6 years ago

Hey, I worked on this issue and opening a pull request. See to it.

NirmalKumarJoshi commented 5 years ago

@0x48piraj I have fixed this under the issue #33 . Suggest other changes.

HemabhKamboj commented 5 years ago

any work left on this issue?

0x48piraj commented 5 years ago

Link the Pull Request.

NirmalKumarJoshi commented 5 years ago

I have fixed the issue. I will generate a PR on Mar 1.

ShubhamChaudharyy commented 4 years ago

Hey I can build the subscribe button but I know the web scraping with puppeteer so should I commit the extension built on puppeteer or You can explain what u have used in this extension.