search

fossasia / accounts.susi.ai

Accounts Service for SUSI.AI http://accounts.susi.ai
GNU Lesser General Public License v2.1
1.5k stars 94 forks source link

modify ui for delete account #688

Closed AdityaSrivast closed 5 years ago

AdityaSrivast commented 5 years ago

Fixes #685

Changes:

Surge Deployment Link: https://pr-688-fossasia-susi-accounts.surge.sh

Screenshots for the change:

image

AdityaSrivast commented 5 years ago

@hkedia321 @Akshat-Jain Can you please review?

AdityaSrivast commented 5 years ago

@AakashMallik Made the changes. Please review

Pipe-Runner commented 5 years ago

@samagragupta I agree... bold looks odd there...

AdityaSrivast commented 5 years ago

@samagragupta @AakashMallik Should I make the font-weight normal for it?

Pipe-Runner commented 5 years ago

Yup.. I think normal font would be the right way to go about it.

AdityaSrivast commented 5 years ago

@AakashMallik @samagragupta I have made the changes. Can you please review again?

AdityaSrivast commented 5 years ago

@samagragupta updated. Sorry, I had forgotten to :sweat_smile:

AdityaSrivast commented 5 years ago

@hkedia321 @akshatnitd @samagragupta Can you please review?

Pipe-Runner commented 5 years ago

@AdityaSrivast https://pr-688-fossasia-susi-accounts.surge.sh/settings this link seems to be broken. Could you please check?

AdityaSrivast commented 5 years ago

@AakashMallik When logged in, https://pr-688-fossasia-susi-accounts.surge.sh/ will take you to the /settings route. You can refer that. It has nothing to do with the code. It's because of single page mechanism of surge. Thanks

Pipe-Runner commented 5 years ago

@AakashMallik When logged in, https://pr-688-fossasia-susi-accounts.surge.sh/ will take you to the /settings route. You can refer that. It has nothing to do with the code. It's because of single page mechanism of surge. Thanks

I don't get it. I logged in and the route broke. What is the single page mechanism you are talking about?