search

fossasia / engelsystem

Shift planning system for events.
http://engelsystem.de
GNU General Public License v2.0
1.51k stars 32 forks source link

Unit Tests for Questions, Settings, User AngelTypes, UserGroups, User, WelcomeMessage model files #208

Closed sreejakshetty closed 8 years ago

sreejakshetty commented 8 years ago

Write unit test for:

DishantK1807 commented 8 years ago

@kamishettysreeja25: I have already written test codes for all the files. There was a mix and match which I was doing while writing the tests. Please work on different issue as you working on this would've waste my time while you were refactoring. Please work on the script and Travis first so that we could integrate the testing fast. I'll write test test codes as I've already writing them. Thank you

sreejakshetty commented 8 years ago

@DishantK1807 There were no issues created for these files. I worked on creating unit test in the milestone 1 https://github.com/fossasia/engelsystem/pull/42. It is easy for me to work on writing tests as I have already worked before and It will be not take much time to finish them. We need tests files to setup travis so it will be fast if we both work on and complete the issue. Thank you.

DishantK1807 commented 8 years ago

@kamishettysreeja25: It'll be easy. But I already worked on them while you were refactoring. You working on these would've waste a lot of mine time then. Please find a different issue. Thank you

DishantK1807 commented 8 years ago

@kamishettysreeja25: Thank you for creating the issues.

sreejakshetty commented 8 years ago

@dishantkhanna Welcome :) On 2 Aug 2016 7:41 a.m., "Dishant Khanna" notifications@github.com wrote:

@kamishettysreeja25 https://github.com/kamishettysreeja25: Thank you for creating the issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/engelsystem/issues/208#issuecomment-236773237, or mute the thread https://github.com/notifications/unsubscribe-auth/AOJg0u-0WCKUqi_kMsyHwAKwG4AD_jjCks5qbqddgaJpZM4JZ2k0 .

DishantK1807 commented 8 years ago

Fixed here: #206