fossasia / eventyay-talk

eventyay speakers and talks component
Apache License 2.0
1.48k stars 47 forks source link

Add co-speaker feature broken #129

Open mariobehling opened 1 month ago

mariobehling commented 1 month ago

When an organiser activates "additional speaker" in the content section the form for speakers shows two areas to enter a speaker email.

a) The top form field works as expected. b) When the speaker adds an email in the second form field nothing happens after saving the form.

This is confusing. Why are there two areas?

However in contrast to eventyay-talk on Pretalx this seems to work. Identify the difference and fix the issue to work in the same way as Pretalx.

Organiser content form Screenshot from 2024-07-19 00-52-50

Speaker form Screenshot from 2024-07-19 00-49-04

Tested on https://wikimania-dev.eventyay.com/

odkhang commented 1 month ago

Hi @mariobehling ,

I have checked Pretalx and see it work the same as eventyay-talk

  1. As the first page when you submit a proposal, and fill in 'Additional Speaker', invitation will be send without any issue

image

  1. But in the edit proposal, it correct as you mentioned, additional Speaker not work.

    => the addtional Speaker only work once when we submit proposal

To prevent the confusing, there're 2 options:

  1. Remove 'Additional Speaker' as we can use this image

  2. Send invitation for 'Additional Speaker' if it added

mariobehling commented 1 month ago

@odkhang @lcduong Yes, I think option 2 would make sense the most for the moment: Send invitation for 'Additional Speaker' if it added

lcduong commented 1 month ago

sure @mariobehling, please help me to review this PR: https://github.com/fossasia/eventyay-talk/pull/130

mariobehling commented 1 month ago

When the speaker field invites a speaker the log message for the session should show "A speaker was invited to the proposal."

Currently the log message is as follows:

Screenshot from 2024-07-20 18-20-36