fossasia / eventyay-talk

eventyay speakers and talks component
Apache License 2.0
1.48k stars 47 forks source link

Add co-speaker feature broken #130

Closed lcduong closed 1 month ago

lcduong commented 1 month ago

This PR closes/references issue #129 . It does so by:

How has this been tested?

Checklist

Summary by Sourcery

This pull request introduces a new feature that sends an invitation email to an additional speaker when specified in the proposal edit form. It includes error handling for email sending failures.

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request implements a feature to send an invitation email to an additional speaker when the 'Additional Speaker' field is filled in the proposal edit form. The changes include adding a check for the 'additional_speaker' field, sending the invitation email, and handling potential email sending errors with appropriate logging and user notifications.

File-Level Changes

Files Changes
src/pretalx/cfp/views/user.py Introduced functionality to send an invitation email to an additional speaker when the 'Additional Speaker' field is filled during proposal editing, including error handling and user notifications.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
mariobehling commented 1 month ago

Thanks this solves the core issue. Please also ensure the log message on the proposal page is showing the action correctly.

When the speaker field invites a speaker the log message for the session should show "A speaker was invited to the proposal."

Currently the log message is as follows:

Screenshot from 2024-07-20 18-20-36