search

fossasia / eventyay-talk

eventyay speakers and talks component
Apache License 2.0
1.48k stars 47 forks source link

Fix speaker view for eventyay-video #145

Closed lcduong closed 1 month ago

lcduong commented 1 month ago

Summary by Sourcery

This pull request addresses a bug in the speaker view by adding validation checks to ensure that the avatar source and license are not empty when the user has an avatar.

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request addresses an issue in the speaker view for eventyay-video by enhancing the avatar source and license retrieval methods. Specifically, it adds checks to ensure that the avatar_source and avatar_license are not empty strings before returning them.

File-Level Changes

Files Changes
src/pretalx/api/serializers/speaker.py Enhanced avatar source and license retrieval methods to ensure non-empty values.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
mariobehling commented 1 month ago

Unforatuntely this PR does not solve the issue yet. Compare: https://wikimania-live.eventyay.com/schedule/speakers