fossasia / eventyay-tickets

https://tickets-dev.eventyay.com
Apache License 2.0
1.51k stars 36 forks source link

Remove jsonfallback: not needed and breaking #112

Closed marcoag closed 1 month ago

marcoag commented 1 month ago

As pointed out in https://github.com/fossasia/eventyay-tickets/pull/98#issuecomment-2123539094, the django-mysql being used doesn't have the connection_is_mariadb function and even though there were efforts to remove that it seems dependencies were not adjusted accordingly. It seems like django-jsonfallback is actually not compatible with the version we use of django-mysql due to the connection_is_mariadb dependency, even at its latest version.

However it seems like #diff-39276994c50b9f2771c0cffec4886e775edcf1c739f13fca75c4c406340119b7 introduced a replacement for [django-jsonfallback](https://github.com/raphaelm/django-jsonfallback/tree/master) functions but missed removing the dependency. Doing it here.

Note that this is untested and only fixing django-jsonfallback there might be other inconsistent dependencies.