Update Paypal to a more recent version

[lcduong]

Fixes #151 Update Paypal to a more recent version

Short description of what this resolves:

Update Paypal to a more recent version

Changes proposed in this pull request:

• Update Paypal to a more recent version

Checklist

• [x] I have read the Contribution & Best practices Guide.
• [x] My branch is up-to-date with the Upstream development branch.
• [ ] The acceptance, integration, unit tests and linter pass locally with my changes
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation (if appropriate)

Summary by Sourcery

This pull request updates the PayPal integration to a more recent version, incorporating the latest PayPal SDKs and APIs. It introduces support for PayPal Alternative Payment Methods (APM), enhances the configuration interface, and improves error handling and logging. The user interface for PayPal payment options has also been enhanced to dynamically render available payment methods.

• New Features:
  • Introduced support for PayPal Alternative Payment Methods (APM) including various local payment methods.
  • Added a new PayPal payment method configuration interface with enhanced settings and options.
  • Implemented a new PayPal payment flow using the PayPal Checkout SDK.
• Enhancements:
  • Refactored the PayPal integration to use the latest PayPal SDKs and APIs.
  • Improved error handling and logging for PayPal transactions.
  • Enhanced the user interface for PayPal payment options, including dynamic rendering of available payment methods.

[mariobehling]

Thank you. Please check the docker build is failing.

[mariobehling]

I cannot get it to run using docker autodeployment. Getting the following errors:

1 error and 7 warnings

• Push Docker image to Docker hub
  • buildx call failed with: ERROR: failed to solve: process "/bin/sh -c chmod +x /usr/local/bin/pretix && rm /etc/nginx/sites-enabled/default && cd /pretix/src && rm -f pretix.cfg && \tmkdir -p data && chown -R pretixuser:pretixuser /pretix /data data && \tsudo -u pretixuser make production" did not complete successfully: exit code: 2
• Push Docker image to Docker hub
  • Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9, docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
• Push Docker image to Docker hub
  • The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9, docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
• Push Docker image to Docker hub
  • The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
• Push Docker image to Docker hub
  • The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
• Push Docker image to Docker hub
  • The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
• Push Docker image to Docker hub
  • The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
• Push Docker image to Docker hub
  • The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

[lcduong]

Hi @mariobehling, this is similar case with Stripe we discussed, if admin did not config Paypal key in global setting, User must config by theirself in paypemt setting, if admin did setup key in global setting, User just will see action to connect with paypal and integrate with Paypal business account set up in global. For more clarify, please see below testing

Testing Admin did not config global key

1. Admin did not setup public key, private key and merchant id in global setting
2. In payment setting of each event, User must connect with Paypal account which will be used only for that event.
3. place order and paid

Admin has configured global key for paypal

1. First we need a business paypal account (for testing, I'm using sandbox account) note private key, public key and account id (merchant id)

2. set noted key in admin global setting

3. There is option connect with Paypal in payment setting for event which not configured yet

4. Now just follow step by step and connect with business paypal account

Enable payment method and start selling your tickets

Please ping me if any confuse.

[mariobehling]

Getting Internal Server Error when accessing the Payment options page of an event.

[mariobehling]

This server error happens after I fill in the Paypal details into the global admin settings page.

[lcduong]

Getting Internal Server Error when accessing the Payment options page of an event.

Hi @mariobehling , could you share with me the logs?

[odkhang]

Hi @mariobehling, issue is fixed, please test it again.

[mariobehling]

@lcduong I am getting

An error occurred during connecting with PayPal, please try again.

[mariobehling]

Could it be that you also need paypal-checkout-serversdk 1.0.* in order to get this working?

[mariobehling]

Please resolve conflicts.

[mariobehling]

@sourcery-ai review

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This pull request updates the PayPal integration to a more recent version, replacing the deprecated paypalrestsdk with the new paypalcheckoutsdk. The changes include significant refactoring of the payment processing logic, updates to the settings and configuration, and enhancements to the user interface for PayPal payments.

File-Level Changes

Files	Changes
src/pretix/plugins/paypal/payment.py src/pretix/plugins/paypal/views.py src/pretix/plugins/paypal/signals.py src/pretix/plugins/paypal/urls.py src/pretix/plugins/paypal/apps.py	Refactored the PayPal integration to use the new paypalcheckoutsdk, updated settings and configuration, and added new views and signal handlers.
src/pretix/base/services/cart.py src/pretix/presale/views/__init__.py	Updated cart and presale views to support the new PayPal payment methods.
src/pretix/plugins/paypal/templates/plugins/paypal/redirect.html src/pretix/plugins/paypal/templates/plugins/paypal/paypal_pay.html src/pretix/plugins/paypal/templates/plugins/paypal/control.html src/pretix/plugins/paypal/templates/plugins/paypal/checkout_payment_confirm.html src/pretix/plugins/paypal/templates/plugins/paypal/checkout_payment_form.html	Added and updated templates to support the new PayPal payment methods and user interface.
src/pretix/plugins/paypal/static/plugins/paypal/paypal.js	Added a new JavaScript file for handling PayPal payments using the new SDK.
src/pretix/plugins/paypal/paypal_http_client.py src/pretix/plugins/paypal/paypal_environment.py	Added new modules for handling HTTP requests and configuring the PayPal environment using the new SDK.

---

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.