fossasia / eventyay-tickets

Apache License 2.0
1.51k stars 41 forks source link

Implement Support for Sendgrid on a System and User Level #195

Closed lcduong closed 2 months ago

lcduong commented 3 months ago

Fixes #108 Implement Support for Sendgrid on a System and User Level

Short description of what this resolves:

Implement Support for Sendgrid on a System and User Level

Changes proposed in this pull request:

  • Implement Support for Sendgrid on a System and User Level

Checklist

  • [x] I have read the Contribution & Best practices Guide.
  • [x] My branch is up-to-date with the Upstream development branch.
  • [ ] The acceptance, integration, unit tests and linter pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
mariobehling commented 3 months ago

Please also change: Screenshot from 2024-06-24 10-07-24

☑ Use Custom Email All mail related to your event will be sent over your specified email gateway.

mariobehling commented 3 months ago

In global settings there should be the info what is the current configuration. This info should be read from the config file.

In the tested system the config was using SMTP, but the SMTP info does not show up in the settings view.

Screenshot from 2024-06-24 10-09-39

norbusan commented 3 months ago

Comments from the video chat today:

mariobehling commented 3 months ago

Please resolve conflicts.

norbusan commented 3 months ago

A few issues and questions:

hongquan commented 2 months ago

Please resolve conflict.

odkhang commented 2 months ago

Hi @mariobehling, conflict is solved, could you help me to check it?

mariobehling commented 2 months ago

Looks like there are a number of changes that result in conflicts again.

odkhang commented 2 months ago

Hi @mariobehling, conflict is resolved.

mariobehling commented 2 months ago

@lcduong @odkhang Please answer the questions of @norbusan

A few issues and questions:

  • does this work with read-only configuration file pretix.cfg?
  • does this support setting the email per organizer/event, or only in the global config file?
mariobehling commented 2 months ago

Feedback during meeting

  • does this work with read-only configuration file pretix.cfg?

Yes, it should be working.

  • does this support setting the email per organizer/event, or only in the global config file?

Yes, it is implemented in that way, but needs further testing in real-world conditions.

mariobehling commented 2 months ago

After merging this PR there is an internal server error, e.g. check here when you invite a team member: https://tickets-dev.eventyay.com/control/organizer/conferenceorganiser/team/1/