search

fossasia / eventyay-tickets

https://tickets-dev.eventyay.com
Apache License 2.0
1.5k stars 35 forks source link

Improve flow for required field of Yes-No question #206

Closed AviGawande closed 2 days ago

AviGawande commented 1 week ago

This PR fixes the issue #174

mariobehling commented 6 days ago

Please resolve conflicts.

hongquan commented 6 days ago

@AviGawande You mentioned about some required attribute but none of your code touch it. Is it because the issue has been fixed by some other PR, or you forgot it?

AviGawande commented 6 days ago

@AviGawande You mentioned about some required attribute but none of your code touch it. Is it because the issue has been fixed by some other PR, or you forgot it?

here in the PR, i mentioned that the "required" attribute not correctly applied,so i just implemented its logic with the "True" value.

AviGawande commented 6 days ago

If the required attribute has been fixed by other PR, the changeset here is Ok to merge.

in this raised PR i had fixed it.

hongquan commented 5 days ago

@AviGawande You mentioned about some required attribute but none of your code touch it. Is it because the issue has been fixed by some other PR, or you forgot it?

here in the PR, i mentioned that the "required" attribute not correctly applied,so i just implemented its logic with the "True" value.

Could you point out which line? None of the changed lines ever touches required.