search

fossasia / eventyay-tickets

Apache License 2.0
1.51k stars 41 forks source link

Adds PostgresSQL and Redis support #45

Closed fillingtothemomo closed 7 months ago

fillingtothemomo commented 7 months ago

Fixes #28 Please review the PR and suggest changes , I guess the required changes are a bit more complicated than the referenced PR.

hongquan commented 7 months ago

You copied the code from upstream https://github.com/pretix/pretix/blob/3b98d87a26d02f3dd72a28452421ce42b6bc6620/src/pretix/settings.py#L126-L143, which is illegal.

You may not understand the scope of the work. eventyay-tickets is a fork of pretix, but at the time pretix changed its license. It means that any code you see in pretix which is later than the forking time, is under license which is not compatible with eventyay-tickets, and eventyay-tickets is not allowed to copy.

fillingtothemomo commented 7 months ago

@hongquan , Apologies for the violation , I wasn't aware of it and was simply trying to follow the linked PR for resolving the issue. I will keep that in mind for resolving further issues. Thanks!