search

fossasia / eventyay-video

https://video-dev.eventyay.com
Apache License 2.0
1.49k stars 22 forks source link

Implement audio translation system #147

Closed odkhang closed 2 months ago

odkhang commented 2 months ago

Fixes #203 Implement translation system as in previous eventyay version

Short description of what this resolves:

Implement translation system as in previous eventyay version

Changes proposed in this pull request:

  • Implement translation system as in previous eventyay version

Checklist

  • [x] I have read the Contribution & Best practices Guide.
  • [x] My branch is up-to-date with the Upstream development branch.
  • [ ] The acceptance, integration, unit tests and linter pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
odkhang commented 2 months ago

Add translation youtube url

image

audio translation dropdown

image

mariobehling commented 2 months ago

Merging this for in-depth testing in dev deployment.

mariobehling commented 2 months ago

This is the first step of the feature.

The functionality should work in the way that the video source always stays the same no matter what language is choosen. But: When the user clicks on another language the audio source changes.