fossasia / eventyay-video

https://video-dev.eventyay.com
Apache License 2.0
1.49k stars 23 forks source link

Speaker detail view error #184

Closed lcduong closed 3 months ago

lcduong commented 3 months ago

There's an error when view speaker info, it keep loading

Related to https://github.com/fossasia/eventyay-video/issues/185

image

rootcause: session got undefined because not sync from talk component to video platform yet

solution: exclude undefined session from speaker profile view

Summary by Sourcery

This pull request addresses a bug in the speaker detail view where the page would keep loading indefinitely. The issue was caused by undefined sessions being included in the speaker's submissions. The fix involves filtering out these undefined sessions to ensure the view loads correctly.

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request addresses an error in the speaker detail view where the page keeps loading due to undefined sessions. The solution involves modifying the sessions computed property in the item.vue file to filter out undefined sessions, ensuring that only valid sessions are processed and displayed.

File-Level Changes

Files Changes
webapp/src/views/schedule/speakers/item.vue Updated the sessions computed property to handle undefined sessions by adding a filter step.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
mariobehling commented 3 months ago

This PR did not solve it. There is now always a string "nulltalk" in the links, e.g. https://wikimania-live.eventyay.com/schedule/speakers/nulltalk/WNSU3P/