Closed untari closed 1 month ago
This pull request adds a switch button to toggle between standard and no-cookies YouTube URLs within the app. The changes include adding a new switch button in the admin room types edit view, introducing a 'noCookies' data property, and updating the YouTube URL construction logic in the MediaSource component to respect the 'noCookies' setting.
Files | Changes |
---|---|
webapp/src/views/admin/rooms/types-edit/stage.vue webapp/src/components/MediaSource.vue |
Introduced a switch button to toggle between standard and no-cookies YouTube URLs and updated the URL construction logic accordingly. |
noted @mariobehling
For the code changes suggestions above, I will test it locally first
@hongquan Thank you for the suggestion, will modify the URL using the URLSearchParams.
A picture showing the toggle switches for embedded YouTube parameters.
Enabling "Autostart" results in the video starting from the beginning of the livestream instead of showing the video at the actual live time. Compare: https://video-dev.eventyay.com/rooms/77b6e3b4-2380-41a7-bb50-1732c998425d/
It also does not do what it is supposed to do: The stream does not start automatically. Is the reason that there is a conflict with the profile option? There is an option to start livestreams automatically, but it also does not work with actual livestreams (only works with recorded videos). Compare: https://wikimania-live.eventyay.com/preferences
This PR closes/references issue: (https://github.com/fossasia/eventyay-video/issues/170) This update introduces a switch button to toggle between standard and no-cookies YouTube URLs within the app.
Summary by Sourcery
This pull request adds a switch button in the admin room types edit view to toggle between standard and no-cookies YouTube URLs. The YouTube URL construction logic has been updated to respect the state of this switch.