fossasia / eventyay-video

https://video-dev.eventyay.com
Apache License 2.0
1.49k stars 22 forks source link

Add Streaming Switch Button for Additional Options #188

Closed untari closed 1 month ago

untari commented 1 month ago

This PR closes/references issue: (https://github.com/fossasia/eventyay-video/issues/170) This update introduces a switch button to toggle between standard and no-cookies YouTube URLs within the app. Screenshot from 2024-08-01 16-06-17

Summary by Sourcery

This pull request adds a switch button in the admin room types edit view to toggle between standard and no-cookies YouTube URLs. The YouTube URL construction logic has been updated to respect the state of this switch.

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request adds a switch button to toggle between standard and no-cookies YouTube URLs within the app. The changes include adding a new switch button in the admin room types edit view, introducing a 'noCookies' data property, and updating the YouTube URL construction logic in the MediaSource component to respect the 'noCookies' setting.

File-Level Changes

Files Changes
webapp/src/views/admin/rooms/types-edit/stage.vue
webapp/src/components/MediaSource.vue
Introduced a switch button to toggle between standard and no-cookies YouTube URLs and updated the URL construction logic accordingly.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
untari commented 1 month ago

noted @mariobehling

For the code changes suggestions above, I will test it locally first

untari commented 1 month ago

@hongquan Thank you for the suggestion, will modify the URL using the URLSearchParams.

untari commented 1 month ago

A picture showing the toggle switches for embedded YouTube parameters. Screenshot from 2024-08-04 23-19-42

mariobehling commented 1 month ago
  1. Enabling "Autostart" results in the video starting from the beginning of the livestream instead of showing the video at the actual live time. Compare: https://video-dev.eventyay.com/rooms/77b6e3b4-2380-41a7-bb50-1732c998425d/ Screenshot from 2024-08-05 00-35-58

  2. It also does not do what it is supposed to do: The stream does not start automatically. Is the reason that there is a conflict with the profile option? There is an option to start livestreams automatically, but it also does not work with actual livestreams (only works with recorded videos). Compare: https://wikimania-live.eventyay.com/preferences

Screenshot from 2024-08-05 00-39-48