fossasia / eventyay-video

https://video-dev.eventyay.com
Apache License 2.0
1.49k stars 22 forks source link

Make left side bar move in/out #192

Open odkhang opened 1 month ago

odkhang commented 1 month ago

Summary by Sourcery

Implement a toggle functionality for the left sidebar, allowing it to move in and out with smooth transitions. Refactor the layout to use fixed positioning for the sidebar and adjust the main content area accordingly.

Enhancements:

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request refactors the sidebar functionality to allow it to move in and out using a button. Key changes include adding ref attributes to key elements, updating the toggleSidebar method to manipulate styles directly, and modifying CSS for smooth transitions. Additionally, several components were updated to ensure full height layout consistency.

File-Level Changes

Files Changes
webapp/src/App.vue
webapp/src/components/RoomsSidebar.vue
webapp/src/components/MediaSource.vue
Refactored sidebar functionality to use direct style manipulation and added a button for toggling the sidebar.
webapp/src/components/Scrollbars.vue
webapp/src/views/rooms/RoomHeader.vue
webapp/src/views/rooms/item.vue
webapp/src/views/schedule/index.vue
Updated various components to ensure full height layout consistency.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
mariobehling commented 1 month ago

Yes, the moving in of the sidebar looks good, but how to handle the mobile view? This breaks the mobile view.

This PR: Screenshot from 2024-08-02 07-24-13 Screenshot from 2024-08-02 07-23-55

Current view on production: Screenshot from 2024-08-02 07-23-37

mariobehling commented 1 month ago

I think we could keep the way it currently works on mobile.