search

fossasia / eventyay-video

https://video-dev.eventyay.com
Apache License 2.0
1.49k stars 23 forks source link

Remove autoplay switch button from room settings UI #196

Closed untari closed 2 months ago

untari commented 2 months ago

This PR addresses the issue discussed here: https://github.com/fossasia/eventyay-video/pull/188#issuecomment-2267838309

It removes the autoplay switch button from the room settings. Livestream videos will autoplay by default, and this setting can be adjusted in the user profile settings. By eliminating the redundant autoplay switch, this update simplifies the user interface and reduces confusion.

Summary by Sourcery

Remove the autoplay switch button from the room settings UI, making livestream videos autoplay by default and allowing this setting to be adjusted in the user profile settings.

Enhancements:

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request removes the autoplay switch button from the room settings UI. The changes include deleting the 'autoStart' bunt-switch component and its associated computed property in 'stage.vue', as well as removing the 'autoStart' parameter from the 'getYoutubeUrl' method in 'MediaSource.vue'. This update simplifies the user interface by eliminating a redundant setting, as autoplay can now be managed through user profile settings.

File-Level Changes

Files Changes
webapp/src/views/admin/rooms/types-edit/stage.vue
webapp/src/components/MediaSource.vue		 Removed the 'autoStart' setting from both the room settings UI and the YouTube URL generation logic.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.