search

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.61k stars 157 forks source link

No Layer named "ball" #187

Closed niccokunzmann closed 7 years ago

niccokunzmann commented 7 years ago

capture When playing the game, sometimes no character is displayed and I get this message.

I would like to see a character there.

There could be a character ball but maybe there is not.

Marauderer97 commented 7 years ago

@niccokunzmann I would like to work on this. However I cannot find any svg file named ball, a similar thing happened with issue #183 , where I couldnot find any svg file named thunder, What do you suggest? image No results are found when I try searching on my terminal

niccokunzmann commented 7 years ago

Currently, we only work on the flappy.svg file.

Marauderer97 commented 7 years ago

@niccokunzmann So how do I look for character ball and fix this?

niccokunzmann commented 7 years ago

You can try grep -r ball

Marauderer97 commented 7 years ago

@niccokunzmann image This is what I got, so should I remove Ball from the list, since it doesnot seem to appear elsewhere(and hence probably doesnot exist?)

niccokunzmann commented 7 years ago

I do not know...

Marauderer97 commented 7 years ago

image @niccokunzmann , I am sorry if I am pestering you, it's just that I am still a bit unfamiliar with the project structure, but look, no Ball.svg listed under characters

niccokunzmann commented 7 years ago

Hi, I like writing to you, so please do it :)

niccokunzmann commented 7 years ago

There are is no ball.svg but ieven if there was, I think, index.html is still only displaying the flappy.svg file. This fale does not use any of the files that are displayed. The files were created, so we can move to another project structure later which does not have only one huge svg file which is hard to edit but many small ones.

niccokunzmann commented 7 years ago

Did this clarify more? Do you have new questions?

Marauderer97 commented 7 years ago

@niccokunzmann Yes, thank you, this helped :) I will try looking for the ball component in flappy.svg file then

Marauderer97 commented 7 years ago

@niccokunzmann , in the flappy svg file, there is no inkscape label with value "ball", This is why the layer is not being rendered. What do you suggest, creating a ball element, or removing ball from the list? image Edit: There is another character blocky, with the exact same issue. image

niccokunzmann commented 7 years ago

I would like to not see such an error.

niccokunzmann commented 7 years ago

@Marauderer97 Thanks for the change!