Closed yusrilia closed 7 years ago
@niccokunzmann Please a have look :D
Have you also added a background for your obstacle layer as they go in pairs. Also add the necessary code to the javascript files for them to work. For help on adding javascript see this PR #129
Thanks for your contribution!
@Baidya99, so, I have to make a background too?
You do not have to. But: The backgrounds and obstacles go together and are activated at the same time. So, you can create a new, empty background or re-use one of the existing ones. As you like.
@niccokunzmann Okay. I think I'd be happy to try to make a background that match with the obstacles I made, just for fun :). Should I draw one and make another pull request then?
I don't know how to code the JS script though.
Hi @reallyly please have a look at the current state of the game @Baidya99 added a background. Could be that everything is to your satisfaction.
Oh, I saw that! Nice job @Baidya99! Anyway, I don't think the outline in my obstacles drawing matches @Baidya99 's background style, so, can I remove the outline and make a new pull request? @niccokunzmann
You can create new pull-requests, whenever you like to change the game.
@reallyly If you don't want to edit the js file you just delete my background and create your one naming it 'Evil'.
@Baidya99 I'm okay with your background.
I edited the
flappy.svg
file add a new obstacle layer named "obstacle".