fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.61k stars 157 forks source link

Added New Obstacles #197

Closed yusrilia closed 7 years ago

yusrilia commented 7 years ago

I edited the flappy.svg file add a new obstacle layer named "obstacle".

daminisatya commented 7 years ago

@niccokunzmann Please a have look :D

sudo-panda commented 7 years ago

Have you also added a background for your obstacle layer as they go in pairs. Also add the necessary code to the javascript files for them to work. For help on adding javascript see this PR #129

niccokunzmann commented 7 years ago

Thanks for your contribution!

yusrilia commented 7 years ago

@Baidya99, so, I have to make a background too?

niccokunzmann commented 7 years ago

You do not have to. But: The backgrounds and obstacles go together and are activated at the same time. So, you can create a new, empty background or re-use one of the existing ones. As you like.

niccokunzmann commented 7 years ago

Task: https://codein.withgoogle.com/dashboard/task-instances/6589571577937920/

yusrilia commented 7 years ago

@niccokunzmann Okay. I think I'd be happy to try to make a background that match with the obstacles I made, just for fun :). Should I draw one and make another pull request then?

I don't know how to code the JS script though.

niccokunzmann commented 7 years ago

Hi @reallyly please have a look at the current state of the game @Baidya99 added a background. Could be that everything is to your satisfaction.

yusrilia commented 7 years ago

Oh, I saw that! Nice job @Baidya99! Anyway, I don't think the outline in my obstacles drawing matches @Baidya99 's background style, so, can I remove the outline and make a new pull request? @niccokunzmann

niccokunzmann commented 7 years ago

You can create new pull-requests, whenever you like to change the game.

sudo-panda commented 7 years ago

@reallyly If you don't want to edit the js file you just delete my background and create your one naming it 'Evil'.

yusrilia commented 7 years ago

@Baidya99 I'm okay with your background.