search

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.6k stars 157 forks source link

Layers in 'layers/' does not work #228

Closed abishekvashok closed 7 years ago

abishekvashok commented 7 years ago

The layers in 'layers/environment/{sea.sv,hull.svg,DayAndNight.svg}andlayers/environement/obstacles` does not work, please make sure they work properly for this is needed very badly. I want the layers/ svg files to able to be displayed as an image (just try to open it with a browser and if nothing pops out you are seeing error!).

Current SVG File's results: image

It shows a blank screen... This is true for all SVG files in layers/ folder

We would need this to proceed in PR #227

Any help @niccokunzmann

niccokunzmann commented 7 years ago

This is all in flappy2.svg, I assume.

abishekvashok commented 7 years ago

@niccokunzmann yep The SVG Files in /layers/environment and /layer/characters are not working.

niccokunzmann commented 7 years ago

These are three questions for to bring across your point of view, I believe: What do you want to achieve? What did you try? What was different from what you expected? Can you edit the description at the top to include the answers?

abishekvashok commented 7 years ago

@niccokunzmann I think it's okay enough!

Marauderer97 commented 7 years ago

@Abhi2424shek have you changed the style attribute to remove "display:none" because once you do.. you can see the layer, by default it is set so, and displayed only when the java script function is called. Hope this helps :).

abishekvashok commented 7 years ago

I called the JavaScript function to display: inherit but let me give a try on this can you mention the exact line no for a reference.

Marauderer97 commented 7 years ago

@Abhi2424shek This is what I mean, the display is set to none for each layer by default.. image

abishekvashok commented 7 years ago

@Marauderer97 k, I will get a fix in then!

abishekvashok commented 7 years ago

@Marauderer97 see the updated issue!

jayvdb commented 7 years ago

@Marauderer97 , is this bug valid?