search

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.6k stars 157 forks source link

Errors #241

Closed Marauderer97 closed 7 years ago

Marauderer97 commented 7 years ago

The PR solves the following problems:

  1. linking dog through clicks
  2. Making thunder hidden
  3. Relocate ball character, to match other character's initial positions
  4. Add separate svg files for ball and dog
abishekvashok commented 7 years ago

@jig08 nice to have you onboard but for squashing commits we have the squash and merge option so that won't be a problem ;)

jigyasa-grover commented 7 years ago

I'd recommend no to use the squash and merge option for so many commits especially the merge ones. Thanks.

@Marauderer97 Could you pls do the needful ?

abishekvashok commented 7 years ago

Yikes you are on a separate branch can you try to give out some previews since it can be achieved locally pls give some screenshots @marauderer97

Marauderer97 commented 7 years ago

Initially the ball was here: image Now it is here: image

Marauderer97 commented 7 years ago

Solves #242

Marauderer97 commented 7 years ago

@Abhi2424shek @jig08 I used squash and merge while merging , so that all the commits are merged as one single commit, is this good?

jigyasa-grover commented 7 years ago

@Marauderer97

Follow the guidelines to be a good contributor to any open source project and/or org.

jigyasa-grover commented 7 years ago

@niccokunzmann Could you pls check who all have the write access to this project ? We'd like to have it limited to protect the sanity :)

niccokunzmann commented 7 years ago

@jig08 It is @Marauderer97 @Abhi2424shek and me. Yes, we should not merge our PR so fast and wait for at least a day but I think, they know it now and will follow this rule :) They support the work flow as we need to merge fast here because flappy.svg can not be merged automatically but is changed almost every time.

@Marauderer97 squashing is good, sure.

Marauderer97 commented 7 years ago

@jig08 My most sincere apologies Firstly, I inferred from your conversation with @Abhi2424shek that you wanted me to squash and merge, and that is why i did it. Secondly, I don't understand which commit message you are talking about? I thought you guys had asked for screenshots, and a related issue which this solves and I commented both of them.. Lastly, most of the things fixed were very minute errors, mostly in layers I had contributed myself, and simply involved creating new files or changing a single word, which is why I was so confident about the PR. However point duly noted. Will be more careful next time. :)

jigyasa-grover commented 7 years ago

@Marauderer97

Thanks.