search

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.6k stars 157 forks source link

Fixed #255: Travis failing; and adding myself to the credits #256

Closed alejoheredia closed 7 years ago

alejoheredia commented 7 years ago

With this PR I solved #255 and I also added myself to the credits page. I hope you like!

You can check my travis build here!

Cheers! 😄

alejoheredia commented 7 years ago

@niccokunzmann Check it please, I have just done it 😄

abishekvashok commented 7 years ago

@Heredroky nice work merging... next time I want to see you squashing the commits pls.

alejoheredia commented 7 years ago

@Abhi2424shek I didn't squash them, because each commit added a different functionality.

alejoheredia commented 7 years ago

@Abhi2424shek It is to have a better order...

abishekvashok commented 7 years ago

@Heredroky but we squash it when merging it, I nor most of the maintainers wont enforce you to squash but I meant that you should learn squashing this competition should also be used to improve your knowledge base :) and next time pls update the comment body to contain a descriptive message and reference the issue number in the commit body.

alejoheredia commented 7 years ago

@Abhi2424shek I already know how to squash...

abishekvashok commented 7 years ago

i just mentioned as I never knew that @Heredroky anyways, Happy coding :)