Closed niccokunzmann closed 6 years ago
Hi @niccokunzmann I would like to work on this.
Go for it
@hemanthsavasere status on this pls
Is this still open? Where do you want the function to be created? in the Start.js or in Characters SVG?
I think, you can choose what feels best for you. If it is created once at start, then it should be in the start.js. However, if you put it in the characters, ....
You can evaluate this.
On 14.04.2017 19:34, Khris Danielle Jalog wrote:
Is this still open? Where do you want the function to be created? in the Start.js or in Characters SVG?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/flappy-svg/issues/259#issuecomment-294197954, or mute the thread https://github.com/notifications/unsubscribe-auth/AAieICucKABrEZBGAs50G2oZEu1jaRELks5rv64kgaJpZM4LjTMH.
@niccokunzmann @abishekvashok I created a pull request solving this issue. Please take a look and let me know if there is anything that needed to be changed
Have a look at https://github.com/fossasia/flappy-svg/pull/258#discussion_r96070640 There, we have all the characters listed.
next_character()
that selects and shows the next characternext_character
function in all the characters