Remove a character's onclick function

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/

Other

1.6k stars 157 forks source link

Remove a character's onclick function #259

Closed niccokunzmann closed 6 years ago

niccokunzmann commented 7 years ago

Have a look at https://github.com/fossasia/flappy-svg/pull/258#discussion_r96070640 There, we have all the characters listed.

[ ] create a function next_character() that selects and shows the next character
[ ] remove the onclick function from the characters
[ ] when the website is loaded: set teh onclick attribute to the next_character function in all the characters

hemanthsavasere commented 7 years ago

Hi @niccokunzmann I would like to work on this.

abishekvashok commented 7 years ago

Go for it

abishekvashok commented 7 years ago

@hemanthsavasere status on this pls

sgripts commented 7 years ago

Is this still open? Where do you want the function to be created? in the Start.js or in Characters SVG?

niccokunzmann commented 7 years ago

I think, you can choose what feels best for you. If it is created once at start, then it should be in the start.js. However, if you put it in the characters, ....

You can evaluate this.

On 14.04.2017 19:34, Khris Danielle Jalog wrote:

Is this still open? Where do you want the function to be created? in the Start.js or in Characters SVG?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/flappy-svg/issues/259#issuecomment-294197954, or mute the thread https://github.com/notifications/unsubscribe-auth/AAieICucKABrEZBGAs50G2oZEu1jaRELks5rv64kgaJpZM4LjTMH.

hkveeranki commented 6 years ago

@niccokunzmann @abishekvashok I created a pull request solving this issue. Please take a look and let me know if there is anything that needed to be changed