search

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.61k stars 157 forks source link

Improved cursors on game over text and buttons #278

Closed foolmoron closed 5 years ago

niccokunzmann commented 5 years ago

With #277, you added css to the svg file. If you would like to avoid conflict, it seems you can add the same css to the index.css file. It seems to be included in the first lines. If not, including a CSS file surely would be of help.

https://raw.githubusercontent.com/fossasia/flappy-svg/f8c473dc6212839991308c10a51d99ed98a95073/flappy.svg

<?xml-stylesheet type="text/css" href="index.css" ?><!-- Created with Inkscape (http://www.inkscape.org/) -->
foolmoron commented 5 years ago

Okay I'll update my PRs. I was trying to link an external CSS file but it doesn't work with embedded SVG like what you're doing. You have to do inline CSS. But I think if you embed with an object tag instead, it could work. I'll try it out!

foolmoron commented 5 years ago

Actually the only issue was the index.css link in the svg had to be style/index.css. I updated my PRs so they should be okay to merge now.