search

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.6k stars 157 forks source link

Changed the Sounds URL #297

Open Asher-MS opened 2 years ago

Asher-MS commented 2 years ago

Change the sound URL from "../flappy-svg/Sounds/Flappy.mp3" to "../Sounds/Flappy.mp3" and "../flappy-svg/Sounds/GameOver.mp3" to "../Sounds/GameOver.mp3"

abishekvashok commented 2 years ago

Can I see some testing please?

Asher-MS commented 2 years ago

Ok sure how should I show the testing??

abishekvashok commented 2 years ago

Show a screencast of it working? Providing a deployment link for anyone to go and test? There are plenty of ways :)

Asher-MS commented 2 years ago

video Link : https://drive.google.com/file/d/1K2ecU8zV9-gYdxPUY-23C4q6HNPvoGuH/view?usp=sharing

abishekvashok commented 2 years ago

Yep seems fine. I will checkout the code locally and get back.

Asher-MS commented 2 years ago

OK Sure✌

Asher-MS commented 2 years ago

Will it be merged?? @abishekvashok