search

fossasia / flappy-svg

Flappy Bird in SVG. Play it at http://fossasia.github.io/flappy-svg/
Other
1.6k stars 157 forks source link

Make circles in links.html to links #97

Closed niccokunzmann closed 8 years ago

niccokunzmann commented 8 years ago

Context The circles in links.html behave as if they should be clickable. When I go over them with the mouse or click them, they change color.

Problem Currently, only the text inside the circles has a behavior although it is suggested that the circles have the same.

Solution Make the circles clickable and do the same that the text inside does now.

jinankjain commented 8 years ago

Just above tag above div would solve that problem I guess @niccokunzmann

niccokunzmann commented 8 years ago

@jinankjain Some JavaScript functions in links.html will need to be changed, too.

Hint: If we put the argument to the functions into a variable, we do not need to touch the content of the links.

SilentFlame commented 8 years ago

@niccokunzmann please have a look to the PR. I have added images to both the Play Store and APK links. hope it's ok to use here.

niccokunzmann commented 8 years ago

@SilentFlame I commented.

AMaini503 commented 8 years ago

@niccokunzmann Is this bug still open to work upon ? I would like to work on it.

niccokunzmann commented 8 years ago

@AMaini503 You could base your work on #98 The idea is to use images and give proper credit. Currently, @SilentFlame is working on it. I suggest, you both communicate.

SilentFlame commented 8 years ago

sorry for my late response, got engaged in my college fest. I'm almost done here just about to submit the final commit, and do some cleaning work. @AMaini503 but, still you can have a look and suggest some further issues if you notice one. Suggestions always welcomed with regards.

SilentFlame commented 8 years ago

@niccokunzmann I think now this issue should be closed.