fossasia / gci18.fossasia.org

FOSSASIA Google Code-In Website 2018 https://gci18.fossasia.org
GNU General Public License v3.0
1.19k stars 96 forks source link

Addition of internal jQuery and Navbar fix #640

Closed roninx991 closed 5 years ago

roninx991 commented 5 years ago

Changes done in this Pull Request

Description / Changes

1. Addition of jquery-

Internal jquery has been added as many libraries depended on it. However addition of internal jquery induced some new issues such as broken slider and navbar issues.

2. Navbar Fix-

Fixed navbar according to theme.

Issues which are still remaining to be fixed

  1. Broken image slider
  2. Code appearing at the bottom of page
  3. Color of drop down menu in the navbar

I will be working on the above issues as well.

Screenshots if any:

Before:

screenshot from 2018-12-23 16-12-22

screenshot from 2018-12-23 17-01-42

screenshot from 2018-12-23 16-12-38

screenshot from 2018-12-23 16-12-44

screenshot from 2018-12-23 16-12-47

screenshot from 2018-12-23 16-12-51

After:

screenshot from 2018-12-23 16-13-24

screenshot from 2018-12-23 16-13-33

screenshot from 2018-12-23 16-13-50

screenshot from 2018-12-23 16-13-55

screenshot from 2018-12-23 16-13-58

screenshot from 2018-12-23 16-14-03


roninx991 commented 5 years ago

@sk9331657 @NishithP2004 @pranav1698 @rctay I have fixed the preview link. Since it was my first PR, I made this small mistake. Please review my PR again. And thanks for the feedback. (PS: There are still some issues yet to be solved and I'm working on it.)

roninx991 commented 5 years ago

@NishithP2004 I don't know, the original repo didn't have gitter link.

roninx991 commented 5 years ago

Thanks @NishithP2004

roninx991 commented 5 years ago

@pranav1698 I'm working on it. Mostly the javascript needs some tweaks. I have mentioned the bugs that are remaining to be solved.