search

fossasia / gci18.fossasia.org

FOSSASIA Google Code-In Website 2018 https://gci18.fossasia.org
GNU General Public License v3.0
1.19k stars 96 forks source link

Added Winners and Finalists #648

Closed NishithP2004 closed 5 years ago

NishithP2004 commented 5 years ago

Changes done in this Pull Request

Description / Changes

I have added the Winners and Finalists to the site.

Screenshots if any:

Before:

After:

NishithP2004 commented 5 years ago

@pranav1698 I have done as requested,please review.

NishithP2004 commented 5 years ago

@sk9331657 I’m not able to centre the image.Please help.

championpaddler commented 5 years ago

@sk9331657 I’m not able to centre the image.Please help.

You have to centre the github icon which is rendered on hovering images.

NishithP2004 commented 5 years ago

@sk9331657 The GitHub Icon is not comming to the middle.What should I do?

supunTE commented 5 years ago

Nice work, but there is something that needs to fix.

You work is great!

NishithP2004 commented 5 years ago

@sahilsaha7773 Please help,as I am not able to position the icon.

NishithP2004 commented 5 years ago

Nice work, but there is something that needs to fix.

  • Squash commits first
  • Solve the issue with GitHub Icon
  • Add contribution winners as well
  • Add more gap between images.
  • Add real images of students, (You can find from GitHub)

You work is great!

Whom should I add as contribution winners? @sk9331657 @sarnava1 @rpotter12

NishithP2004 commented 5 years ago

@sk9331657 @sarnava1 @rpotter12 Please reply for the former.

NishithP2004 commented 5 years ago

Nice work, but there is something that needs to fix.

  • Squash commits first
  • Solve the issue with GitHub Icon
  • Add contribution winners as well
  • Add more gap between images.
  • Add real images of students, (You can find from GitHub)

You work is great!

Whom should I add as contribution winners? @sk9331657 @sarnava1 @rpotter12

supunTE commented 5 years ago

@sk9331657 I’m not able to centre the image.Please help.

If you're unable to complete it, collaborate with someone else.

NishithP2004 commented 5 years ago

@STEdirisuriya could you please collaborate with me.

NishithP2004 commented 5 years ago

@pranav1698 Yeah I had done the changes according to that but it still doesn’t work.

supunTE commented 5 years ago

Use the css code in mentors section, for this too.

NishithP2004 commented 5 years ago

Use the css code in mentors section, for this too.

The same code is used @STEdirisuriya

sahilsaha7773 commented 5 years ago

@NishithP2004 You should use these codes in your index.html file.

1-35 36-68 69-99

You can find the above codes in this file

  1. Add the real pictures from GitHub profiles.
  2. This section can be just after "What is FOSSASIA" section.
  3. Squash your commits.
NishithP2004 commented 5 years ago

@NishithP2004 You should use these codes in your index.html file.

1-35 36-68 69-99

You can find the above codes in this file

  1. Add the real pictures from GitHub profiles.
  2. This section can be just after "What is FOSSASIA" section.
  3. Squash your commits.

@sahilsaha7773 Its done as requested

NishithP2004 commented 5 years ago

@sarnava1 @sk9331657 @abishekvashok @rpotter12 Please review.

NishithP2004 commented 5 years ago

@abishekvashok Please merge