search

fossasia / labs.fossasia.org

Projects Website for FOSSASIA http://labs.fossasia.org
1.67k stars 248 forks source link

Added scroll to top button #390

Closed anishagg17 closed 4 years ago

anishagg17 commented 4 years ago

Hnet com-image-2

mariobehling commented 4 years ago

Please also provide a link for testing where you deployed the website on gh-pages.

anishagg17 commented 4 years ago

preview at : https://anishagg17.github.io/labs.fossasia.org/

mariobehling commented 4 years ago

Often back to top buttons fade in when the user moves the page and fade out when the user stops interacting with the page. Could you try to make this work in the same way, please?

anishagg17 commented 4 years ago

@mariobehling i have done changes as they were supposed. Please have a look https://anishagg17.github.io/labs.fossasia.org/

mariobehling commented 4 years ago

Please check the fade-in delay. This delay is too long.

anishagg17 commented 4 years ago

Please have a look https://anishagg17.github.io/labs.fossasia.org/

mariobehling commented 4 years ago

Please also make it work nicely on mobile.

Screenshot_20191214_102901_com android chrome

anishagg17 commented 4 years ago

It's working fine on my device can you please explain what problem are you facing.

mariobehling commented 4 years ago

The screen should only be scrollable up and down. Your changes result in a horizontal scroll bar.

anishagg17 commented 4 years ago

I have updated please have a view

mariobehling commented 4 years ago

Oh that problem was already there before. I will open an issue. Thanks.

mariobehling commented 4 years ago

Please only make changes in this PR, which are related to the issue. Thanks.

anishagg17 commented 4 years ago

I have reverted all changes to only those which are related to the pr

mariobehling commented 4 years ago

Please only change files, if needed, e.g. script.js still shows up as edited. This is not needed. There is also a .DS file for no reason.

anishagg17 commented 4 years ago

Sir ,I haven't changed any thing in scripts.js I have tried a lot to revert it but I couldn't

anishagg17 commented 4 years ago

Sir actually that new line in scripts.js is added by github You may refer to this article: https://stackoverflow.com/questions/51049503/github-markdown-that-respects-newlines

It occurs because scripts.js file was untouched after git updated .Since now I made a change and reverted it Git detects that file and inserted new line at the end of file