search

fossasia / labs.fossasia.org

Projects Website for FOSSASIA http://labs.fossasia.org
1.67k stars 248 forks source link

update grey color #395

Closed huonggiangbui closed 4 years ago

huonggiangbui commented 4 years ago

Fixes #392 Preview link: https://huonggiangbui.github.io/labs.fossasia.org/

mariobehling commented 4 years ago

Your changes resulted in the social media section not being gray anymore and the red colored section has a kind of line somehow.

Screenshot from 2019-12-13 20-35-09

mariobehling commented 4 years ago

Oh, it seems the issue with the red line got in a bit earlier. Need to check where that change happened.

mariobehling commented 4 years ago

Ok, the gray color thing is fixed now. Please try another issue. Please try to check your changes in detail to ensure things can progress quickly. Thanks!

huonggiangbui commented 4 years ago

@mariobehling did you merged my commit? I see that the PR and isue were closed but the PR seemed not merged yet

mariobehling commented 4 years ago

I took care of it. Unfortunately your code was not working as expected. Please try more at follow up tasks.