add a song change dialog

fossasia / labyrinth

FOSSASIA Labyrinth

GNU Affero General Public License v3.0

1.52k stars 147 forks source link

add a song change dialog #1036

Closed pythongiant closed 5 years ago

pythongiant commented 5 years ago

fix styles:

fix styles

[x] Read and understood see CONTRIBUTING.md
[x] Included a preview link and screenshot showing after and before the changes.
[x] Included a description of change below.
[x] Tried to squash the commits.
[x] Added Screenshot / Path to tile to Indicate Location of Change in Game

Changes done in this Pull Request

View my work at https://pr-1036-fossasia-labyrinth.surge.sh https://pythongiant.github.io/labyrinth/

Fixes #1035

The problem I want to solve or the facility I want to improve is/are

Screenshots,Path to Tile

saarthakchats commented 5 years ago

also, show the names of the creators everywhere

pythongiant commented 5 years ago

@saarthakchats check it out now. Did some changes you requested

pythongiant commented 5 years ago

@saarthakchats I can make the pointer but what do you mean by a hover

pythongiant commented 5 years ago

did the pointer

pythongiant commented 5 years ago

@YashKumarVerma

saarthakchats commented 5 years ago

Hover effect

saarthakchats commented 5 years ago

The colour should become lighter or something like that on hover

saarthakchats commented 5 years ago

did the pointer

It's not correct; either play the song on clicking anywhere on the box, or only change the pointer ont the play button. It feels like the entire block is a button to play but it is not.

pythongiant commented 5 years ago

got it. making changes

pythongiant commented 5 years ago

@saarthakchats check it out now. did all changes you asked.

saarthakchats commented 5 years ago

It's not correct; either play the song on clicking anywhere on the box, or only change the pointer ont the play button. It feels like the entire block is a button to play but it is not.

This is not fixed

pythongiant commented 5 years ago

Ummm i think there is a misunderstanding here @saarthakchats. Would you please tell me which block are we actually talking about here? If its the block where we click the song by clicking the play button the song is playing. Thanks

saarthakchats commented 5 years ago

did the pointer

It's not correct; either play the song on clicking anywhere on the box, or only change the pointer on the play button. It feels like the entire block is a button to play but it is not.

The blocks in your dropdown list

pythongiant commented 5 years ago

Oops forgot to push changes to my gh branch. Lemme do that and should work

pythongiant commented 5 years ago

@saarthakchats everything should be alright now

pythongiant commented 5 years ago

@YashKumarVerma @abishekvashok check this out ?

saarthakchats commented 5 years ago

did the pointer

It's not correct; either play the song on clicking anywhere on the box, or only change the pointer ont the play button. It feels like the entire block is a button to play but it is not.

This is still not fixed

pythongiant commented 5 years ago

the pointer only changes when hovering on the play button. please clear your browser cache and see again @saarthakchats. you can even browse through the code. please look into it

YashKumarVerma commented 5 years ago

Can the play button color be white ?

pythongiant commented 5 years ago

Hmm @YashKumarVerma I am pretty sure that's due to some style defined previously. Still lemme see what I can do about this

pythongiant commented 5 years ago

@YashKumarVerma @saarthakchats I deleted the unnecessary hover changes. check it out now. CC: @abishekvashok

abishekvashok commented 5 years ago

Thanks, great work!