fossasia / labyrinth

FOSSASIA Labyrinth
GNU Affero General Public License v3.0
1.52k stars 147 forks source link

Revert "Resized all images to fix Travis checks" #1045

Closed niccokunzmann closed 5 years ago

niccokunzmann commented 5 years ago

Reverts fossasia/labyrinth#1021 Reverting this as a possible fix for #1026 and to deploy it and have a look.

https://pr-1045-fossasia-labyrinth.surge.sh

niccokunzmann commented 5 years ago

This fixes the issue #1026. However, it does not fix the build.

bundle exec img_checker
66 image(s) have greater dimensions then specified.
Starting Image Checker version 1.3
The image ./tiles/rooms/floor/programmer.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/redFloor.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/landscape.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/wooden.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/sofa.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/orchestra.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/Monster.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/new.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/texture.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/HandDrawnTile.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/cricketGround.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/quake.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/yellowFloor.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/universeFloor.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/Random.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/goal.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/mountainsFloor.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/art.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/bubbleMesh.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/staircase.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/marina.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/treasureKey.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/glowL.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/guitar_case.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/mushroom.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/treasure.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/orangeFloor.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/river.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/graphics.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/Forest.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/quirky.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/banner-1.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/floorNewYear.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/caro.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/drawnPond.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/minecraftEntry.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/Forbidden.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/self_made.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/CreativeRoomFloor.png is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/coolsunbull.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/Desert.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/blood.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/saarthakdraw.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/live.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/banner-Chess.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/black.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/drought.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/drawnbysahil.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/minecraft.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/handarjun.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/chocolate.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/out.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/plain.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/bloodfloor.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/fabricate.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/staircase.png is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/batcave.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/handy.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/nightfloor.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/camel.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/hand-drawn-lines.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/handDrawnBoxes.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/boat.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/drawn.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/BeautifulMesh.svg is larger than 429.544px x 256.314px [w x h]
The image ./tiles/rooms/floor/highLow.svg is larger than 429.544px x 256.314px [w x h]
Image Checker: These images exceeds the specified dimensions
The command "bundle exec img_checker" failed and exited with 1 during .
niccokunzmann commented 5 years ago

https://github.com/fossasia/labyrinth/blob/master/img_config.yml is the configuration for the image checker, added in #963.

niccokunzmann commented 5 years ago

@saarthakchats @abishekvashok before I try to do it by myself, I would value your input as you have worked on the checks as I can see and have experience. What do you think? Do you have suggestions?

saarthakchats commented 5 years ago

The image tracker will naturally fail as this PR reverts the resizing.. the other issue was with rake That I dont know who put in the checks.. you can look around and try to fix @niccokunzmann

abishekvashok commented 5 years ago

Let's merge it here, and for individual tiles maybe we should really take a look and see how they should be scaled. Let's make the game playable now

abishekvashok commented 5 years ago

Thanks