Implementing Oauth using GoogleSignIn API

fossasia / labyrinth

FOSSASIA Labyrinth

GNU Affero General Public License v3.0

1.52k stars 147 forks source link

Implementing Oauth using GoogleSignIn API #1059

Closed ShubhamChaudharyy closed 5 years ago

ShubhamChaudharyy commented 5 years ago

implemented Oauth (thats my third Pull request and learnt quite few things in each pull 👍 ) Used the API token for Google Oauth feature. Note: Please Obtain your security Token as i cannot deploy my API token thats why i have left a comment in index.html in meta tag " content= ".

[x] Read and understood [see CONTRIBUTING.md]
[x] Included a description of change below.
[x] Tried to [squash the commits][squash].

Changes done in this Pull Request

Fixes #618

ezgif com-video-to-gif

ShubhamChaudharyy commented 5 years ago

@YashKumarVerma please review

NishithP2004 commented 5 years ago

Please provide a preview link.

NishithP2004 commented 5 years ago

According to the gif it seems to be a nice idea.

ShubhamChaudharyy commented 5 years ago

https://labyrinth2.surge.sh/ here is the link to check @NishithP2004

ShubhamChaudharyy commented 5 years ago

i have updated meta tag @YashKumarVerma

YashKumarVerma commented 5 years ago

the work done is awesome, it would be great if you could squash the commits.

ShubhamChaudharyy commented 5 years ago

Okay ,i will be careful next time

YashKumarVerma commented 5 years ago

Okay ,i will be careful next time

can you squash your commits into one ?

ShubhamChaudharyy commented 5 years ago

Okay ,i will be careful next time

can you squash your commits into one ?

okay

YashKumarVerma commented 5 years ago

Closing in support of #1061