fossasia / labyrinth

FOSSASIA Labyrinth
GNU Affero General Public License v3.0
1.52k stars 147 forks source link

Deploy the Game with gh-pages or with a Sub Domain #600

Open NaviRocker opened 6 years ago

NaviRocker commented 6 years ago

Expected results

Game being played in fossasia.github.io/labyrinth or in labyrinth.fossasia.org

Actual results

Now the Game can be played with only rawgit.com/fossasia/labyrinth/master/index.html

Steps to reproduce the issue

Deploy the Game with gh-pages and with CNAME

Ping @niccokunzmann

nzec commented 6 years ago

@naveentherocker We will use RawGit for development because it just copies the code from GitHub, so it is very fast.

@niccokunzmann We can have a subdomain which gets all its data from cdn.rawgit.com

niccokunzmann commented 6 years ago

The good thing about raw git for both development and deployment is that we can detect the same mistakes which might not occur sometimes because of domain and https and path:

With adding gh-pages/domain, we add these possible errors:

So, if we introduce this, we need documentation on what the goal is and which errors to avoid.

38

niccokunzmann commented 6 years ago

I created the gh-pages branch.

niccokunzmann commented 6 years ago

Just adding a gh-pages branch does not seem to activate github pages.

nzec commented 6 years ago

@niccokunzmann Can't you access the settings of this repository? Are the owners required?

himanshuc3 commented 6 years ago

It would be great if the site could be served on gh-pages. Could you make it possible @niccokunzmann .

nzec commented 6 years ago

@himanshuc3 Rawgit is a lot better for development. It displays the content directly from GitHub. So updating is almost instant.

We can start using gh-pages once we have a semi working thing going.

himanshuc3 commented 6 years ago

I see. Fine.