search

fossasia / libsigrok

Read-only mirror of the official repo at git://sigrok.org/libsigrok. Pull requests welcome. Please file bugreports at sigrok.org/bugzilla.
https://sigrok.org/wiki/Libsigrok
GNU General Public License v3.0
333 stars 8 forks source link

pslab device scan implemented #4

Closed kartikaysharma01 closed 3 years ago

kartikaysharma01 commented 3 years ago

The code scans all ports for PSLab device and instantiates the device and its channels Fixes #3

How to test Use the following command on sigrok-cli to scan device ./sigrok-cli --scan

kartikaysharma01 commented 3 years ago

@orangecms @bessman @CloudyPadmal @bessman This PR is ready for review

kartikaysharma01 commented 3 years ago

To keep the patch smaller, retaining the format would be beneficial, both for upstreaming the patch set and also to make the review easier.

working on that

kartikaysharma01 commented 3 years ago

@bessman @orangecms I think we can merge this one

bessman commented 3 years ago

I think so as well, I just have to double check it. Thanks for your patience, kinda swamped at work rn.

kartikaysharma01 commented 3 years ago

Looks good! You recently pushed another commit, are there more coming or can we merge?

There will be some changes as we move ahead, but we can merge this.

bessman commented 3 years ago

Great, thanks! For future reference, once a PR is in a mergeable state, please push further changes to a separate branch/PR.