fossasia / loklak_search

Frontend Search for loklak server https://loklak.org

GNU Lesser General Public License v3.0

1.83k stars 573 forks source link

Shifts Profile section above Top Twitterers and Top hashtags #939

Closed shreyanshdwivedi closed 5 years ago

shreyanshdwivedi commented 5 years ago

Changes proposed in this pull request

I have shifted profile section above top twitterers and top hashtags on search result of from: user_name
I have fixed broken frontend when banner image for twitter profile is absent. If banner image is present, then it is displayed.

Screenshots (if appropriate) Before screenshot_2018-12-15 loklak search - distributed search for twitter and social media with peer to peer technology 1

Now screenshot_2018-12-15 loklak search - distributed search for twitter and social media with peer to peer technology 2

screenshot_2018-12-15 loklak search - distributed search for twitter and social media with peer to peer technology 3

Link to live demo: http://pr-939-fossasia-loklaksearch.surge.sh

Closes #915

codecov[bot] commented 5 years ago

Codecov Report

Merging #939 into development will decrease coverage by 0.01%. The diff coverage is 0%.

@@               Coverage Diff               @@
##           development     #939      +/-   ##
===============================================
- Coverage        50.74%   50.72%   -0.02%     
===============================================
  Files              109      109              
  Lines             2684     2685       +1     
  Branches           302      302              
===============================================
  Hits              1362     1362              
- Misses            1290     1291       +1     
  Partials            32       32

Impacted Files	Coverage Δ
.../app/feed/user-info-box/user-info-box.component.ts	`50% <0%> (-2.64%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f9a033...07ea535. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #939 into development will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #939   +/-   ##
============================================
  Coverage        50.74%   50.74%           
============================================
  Files              109      109           
  Lines             2684     2684           
  Branches           302      302           
============================================
  Hits              1362     1362           
  Misses            1290     1290           
  Partials            32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f9a033...07ea535. Read the comment docs.

shreyanshdwivedi commented 5 years ago

@praveenojha33 @simsausaurabh please review.