search

fossasia / loklak_search

Frontend Search for loklak server https://loklak.org
GNU Lesser General Public License v3.0
1.83k stars 573 forks source link

Adds test for feed-advanced-search component to increase coverage #944

Closed shreyanshdwivedi closed 5 years ago

shreyanshdwivedi commented 5 years ago

Changes proposed in this pull request

Link to live demo: http://pr-944-fossasia-loklaksearch.surge.sh

Related to #414

codecov[bot] commented 5 years ago

Codecov Report

Merging #944 into development will increase coverage by 2.81%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #944      +/-   ##
===============================================
+ Coverage        51.03%   53.85%   +2.81%     
===============================================
  Files              109      109              
  Lines             2700     2700              
  Branches           302      302              
===============================================
+ Hits              1378     1454      +76     
+ Misses            1290     1215      -75     
+ Partials            32       31       -1
Impacted Files Coverage Δ
src/app/reducers/query.ts 76.66% <0%> (+19.99%) :arrow_up:
src/app/actions/query.ts 86.2% <0%> (+20.68%) :arrow_up:
src/app/reducers/news-status.ts 100% <0%> (+33.33%) :arrow_up:
src/app/actions/news.ts 100% <0%> (+40%) :arrow_up:
...-advanced-search/feed-advanced-search.component.ts 100% <0%> (+70.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7de228c...1ea2b73. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #944 into development will increase coverage by 2.81%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #944      +/-   ##
===============================================
+ Coverage        51.03%   53.85%   +2.81%     
===============================================
  Files              109      109              
  Lines             2700     2700              
  Branches           302      302              
===============================================
+ Hits              1378     1454      +76     
+ Misses            1290     1215      -75     
+ Partials            32       31       -1
Impacted Files Coverage Δ
src/app/reducers/query.ts 76.66% <0%> (+19.99%) :arrow_up:
src/app/actions/query.ts 86.2% <0%> (+20.68%) :arrow_up:
src/app/reducers/news-status.ts 100% <0%> (+33.33%) :arrow_up:
src/app/actions/news.ts 100% <0%> (+40%) :arrow_up:
...-advanced-search/feed-advanced-search.component.ts 100% <0%> (+70.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7de228c...1ea2b73. Read the comment docs.

shreyanshdwivedi commented 5 years ago

@praveenojha33 @simsausaurabh please review :)

shreyanshdwivedi commented 5 years ago

@simsausaurabh @praveenojha33 please review