shreyanshdwivedi commented 5 years ago

Changes proposed in this pull request

Adds tests for feed-linker and feed-footer component

Screenshots (if appropriate)

Link to live demo: http://pr-946-fossasia-loklaksearch.surge.sh

Related to #414

codecov[bot] commented 5 years ago

Codecov Report

Merging #946 into development will increase coverage by 2.7%. The diff coverage is n/a.

@@              Coverage Diff               @@
##           development     #946     +/-   ##
==============================================
+ Coverage        54.27%   56.97%   +2.7%     
==============================================
  Files              109      109             
  Lines             2701     2701             
  Branches           302      302             
==============================================
+ Hits              1466     1539     +73     
+ Misses            1186     1100     -86     
- Partials            49       62     +13

Impacted Files	Coverage Δ
src/app/utils/array.ts	`90.9% <0%> (+4.54%)`	:arrow_up:
src/app/feed/feed-footer/feed-footer.component.ts	`100% <0%> (+50%)`	:arrow_up:
src/app/feed/feed-linker/feed-linker.component.ts	`74.1% <0%> (+57.14%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87f9cfe...26a552b. Read the comment docs.

shreyanshdwivedi commented 5 years ago

@simsausaurabh @praveenojha33 please review

shreyanshdwivedi commented 5 years ago

@praveenojha33 please review

shreyanshdwivedi commented 5 years ago

@simsausaurabh please merge

shreyanshdwivedi commented 5 years ago

@simsausaurabh please review

simsausaurabh commented 5 years ago

@shreyanshdwivedi For your future PRs for increasing test coverage try only to add something meaningful to test since you have got familiar with writing test cases for the current codebase.

fossasia / loklak_search

Adds tests for feed-linker and feed-footer component #946

Codecov Report