search

fossasia / loklak_search

Frontend Search for loklak server https://loklak.org
GNU Lesser General Public License v3.0
1.83k stars 573 forks source link

Adds tests for feed-info-box and feed-user-info-box component #948

Closed shreyanshdwivedi closed 5 years ago

shreyanshdwivedi commented 5 years ago

Changes proposed in this pull request

Link to live demo: http://pr-947-fossasia-loklaksearch.surge.sh

Related to #414

codecov[bot] commented 5 years ago

Codecov Report

Merging #948 into development will increase coverage by 3.96%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           development   #948      +/-   ##
=============================================
+ Coverage        51.03%    55%   +3.96%     
=============================================
  Files              109    109              
  Lines             2700   2700              
  Branches           302    302              
=============================================
+ Hits              1378   1485     +107     
+ Misses            1290   1167     -123     
- Partials            32     48      +16
Impacted Files Coverage Δ
src/app/utils/array.ts 90.9% <0%> (+4.54%) :arrow_up:
src/app/lazy-img/lazy-img.service.ts 62.22% <0%> (+8.88%) :arrow_up:
src/app/lazy-img/lazy-img.component.ts 76.56% <0%> (+14.06%) :arrow_up:
.../app/feed/user-info-box/user-info-box.component.ts 100% <0%> (+47.36%) :arrow_up:
src/app/feed/info-box/info-box.component.ts 78.41% <0%> (+60.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7de228c...39d1b96. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #948 into development will increase coverage by 3.48%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #948      +/-   ##
===============================================
+ Coverage        54.27%   57.75%   +3.48%     
===============================================
  Files              109      109              
  Lines             2701     2701              
  Branches           302      302              
===============================================
+ Hits              1466     1560      +94     
+ Misses            1186     1078     -108     
- Partials            49       63      +14
Impacted Files Coverage Δ
src/app/utils/array.ts 90.9% <0%> (+4.54%) :arrow_up:
.../app/feed/user-info-box/user-info-box.component.ts 100% <0%> (+47.36%) :arrow_up:
src/app/feed/info-box/info-box.component.ts 78.41% <0%> (+60.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87f9cfe...c5b7ee3. Read the comment docs.

shreyanshdwivedi commented 5 years ago

@simsausaurabh @praveenojha33 please review

shreyanshdwivedi commented 5 years ago

@simsausaurabh @praveenojha33 please review

shreyanshdwivedi commented 5 years ago

@simsausaurabh please review

shreyanshdwivedi commented 5 years ago

@simsausaurabh please review :)

simsausaurabh commented 5 years ago

@shreyanshdwivedi For your future PRs for increasing test coverage try only to add something meaningful to test since you have got familiar with writing test cases for the current codebase.