fossasia / loklak_search

Frontend Search for loklak server https://loklak.org
GNU Lesser General Public License v3.0
1.83k stars 573 forks source link

edit-form-validation #970

Open Aaryan-kapur opened 4 years ago

Aaryan-kapur commented 4 years ago

Changes proposed in this pull request

please check and suggest improvements, if any!

screenshots ss1 ss

http://pr-970-fossasia-loklaksearch.surge.sh

Closes #936

Thank You, Aaryan-Kapur aaryankapur1309@gmail.com (+91)-7507442555

codecov[bot] commented 4 years ago

Codecov Report

Merging #970 into development will increase coverage by 0.02%. The diff coverage is 60%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #970      +/-   ##
===============================================
+ Coverage         64.9%   64.92%   +0.02%     
===============================================
  Files              109      109              
  Lines             2701     2703       +2     
  Branches           302      303       +1     
===============================================
+ Hits              1753     1755       +2     
  Misses             865      865              
  Partials            83       83
Impacted Files Coverage Δ
...app/contact/contact-form/contact-form.component.ts 64% <40%> (ø) :arrow_up:
src/app/feed/info-box/info-box.component.ts 78.72% <64%> (+0.3%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5690c07...0fc25a2. Read the comment docs.

Aaryan-kapur commented 4 years ago

hey please check this out, @Achint08 @sk9331657

Achint08 commented 4 years ago

I think this PR solves the validation part (which is good) but doesn't solve the whole issue as the formspree is returning 403. otherwise LGTM .

Dishebh commented 4 years ago

@Aaryan-kapur Pls squash your commits.