Open Aaryan-kapur opened 4 years ago
Merging #971 into development will increase coverage by
3.29%
. The diff coverage is62.85%
.
@@ Coverage Diff @@
## development #971 +/- ##
===============================================
+ Coverage 61.60% 64.90% +3.29%
===============================================
Files 109 109
Lines 2701 2704 +3
Branches 302 303 +1
===============================================
+ Hits 1664 1755 +91
+ Misses 952 866 -86
+ Partials 85 83 -2
Impacted Files | Coverage Δ | |
---|---|---|
...app/contact/contact-form/contact-form.component.ts | 61.53% <33.33%> (-2.47%) |
:arrow_down: |
src/app/feed/info-box/info-box.component.ts | 78.72% <64.00%> (+0.30%) |
:arrow_up: |
.../app/feed/user-info-box/user-info-box.component.ts | 100.00% <100.00%> (ø) |
|
src/app/shared/url-config.ts | 100.00% <0.00%> (ø) |
|
src/app/actions/query.ts | 100.00% <0.00%> (+20.68%) |
:arrow_up: |
src/app/reducers/query.ts | 90.00% <0.00%> (+23.33%) |
:arrow_up: |
...ckground/media-wall-custom-background.component.ts | 100.00% <0.00%> (+27.27%) |
:arrow_up: |
...ustom-header/media-wall-custom-header.component.ts | 100.00% <0.00%> (+30.76%) |
:arrow_up: |
src/app/reducers/news-status.ts | 100.00% <0.00%> (+33.33%) |
:arrow_up: |
...ll-custom-card/media-wall-custom-card.component.ts | 100.00% <0.00%> (+33.33%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 50d06b0...7f34cca. Read the comment docs.
@Aaryan-kapur Where is your deployment link
@sk9331657 hey please checkout the link!! http://pr-971-fossasia-loklaksearch.surge.sh/
@sk9331657 please check
@Aaryan-kapur pls squash your commits. Also, see why codacy check is failing. Thanks.
any updates @Dishebh ?
Any updates @Dishebh
LGTM
@sk9331657 is this still relevant and mergable?
fixed issue #925 fixed the overflowing during searches
** http://pr-971-fossasia-loklaksearch.surge.sh
Closes #925
please suggest changes!
Thank You, Aaryan Kapur
@praveenojha33 @kpulkit29 @rajvaibhavdubey