fossasia / loklak_webclient

loklak web application
http://loklak-web.herokuapp.com
MIT License
1.56k stars 49 forks source link

Clean up unused libraries with the npm install packages. #142

Closed sudheesh001 closed 9 years ago

sudheesh001 commented 9 years ago

The repository is bulky as of now with lots of packages, we are not sure if we're even using all the packages, this definitely needs a clean up.

aneeshd16 commented 9 years ago

Agree. Can you test and then document?

aneeshd16 commented 9 years ago

I used this https://www.npmjs.com/package/depcheck to check our dependencies. It returned this:

Unused Dependencies
* bootstrap
* imagesloaded
* jquery
* jquery-browserify
* masonry-layout

Unused devDependencies
* angular-leaflet-directive
* angular-mocks
* bootstrap-sass
* browserify-shim
* bulkify
* gulp-rename
* imagemin-pngcrush
* jshint-stylish
* karma-babel-preprocessor
* karma-browserify
* karma-chrome-launcher
* karma-coverage
* karma-firefox-launcher
* karma-jasmine
* uglifyify

I think we can safely remove these:

* karma-babel-preprocessor
* karma-browserify
* karma-chrome-launcher
* karma-coverage
* karma-firefox-launcher
* karma-jasmine
* angular-leaflet-directive

Not sure about the others.

Also, can we document a few tests to be done for each of the different modules: search, wall, twitter auth, maps so that we can check if this works.

sudheesh001 commented 9 years ago

I think @prasht63 Is using angular-leaflet-directive and other leaflet related things.

aneeshd16 commented 9 years ago

I think he is not using the directive but using the original library, uhh directly. @prasht63 please clarify.

prasht63 commented 9 years ago

Not using the angular-leaflet-directive , full of bugs. Will remove it in the latest commit.

On Thu, Jun 11, 2015 at 12:15 PM, Aneesh Devasthale < notifications@github.com> wrote:

I think he is not using the directive but using the original library, uhh directly. @prasht63 https://github.com/prasht63 please clarify.

— Reply to this email directly or view it on GitHub https://github.com/loklak/loklak_webclient/issues/142#issuecomment-111014810 .

sudheesh001 commented 9 years ago

I used https://www.npmjs.com/package/npm-check and ended up with this result.

karma-coverage             😎  NEW VER!  NonSemver update available: https://github.com/karma-runner/karma-coverage#readme
                                        npm install --save karma-coverage@0.4.2 to go from 0.2.6 to 0.4.2

bootstrap                  😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save bootstrap to remove.

masonry-layout             😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save masonry-layout to remove.

imagesloaded               😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save imagesloaded to remove.

karma-babel-preprocessor   😎  MAJOR UP  Major update available: https://github.com/babel/karma-babel-preprocessor
                                        npm install --save karma-babel-preprocessor@5.2.1 to go from 4.0.1 to 5.2.1

karma-jasmine              😎  NEW VER!  NonSemver update available: https://github.com/karma-runner/karma-jasmine
                                        npm install --save karma-jasmine@0.3.5 to go from 0.1.5 to 0.3.5

jquery-browserify          😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save jquery-browserify to remove.

jquery                     😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save jquery to remove.

istanbul                   😎  NEW VER!  NonSemver update available: https://github.com/gotwarlost/istanbul
                                        npm install --save istanbul@0.3.15 to go from 0.3.14 to 0.3.15

gulp-rename                😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save-dev gulp-rename to remove.

babelify                   😎  MAJOR UP  Major update available: https://github.com/babel/babelify
                                        npm install --save-dev babelify@6.1.2 to go from 5.0.5 to 6.1.2

bootstrap-sass             😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save-dev bootstrap-sass to remove.

browser-sync               😎  MAJOR UP  Major update available: http://www.browsersync.io/
                                        npm install --save-dev browser-sync@2.7.10 to go from 1.9.2 to 2.7.10

browserify                 😎  MAJOR UP  Major update available: https://github.com/substack/node-browserify#readme
                                        npm install --save-dev browserify@10.2.4 to go from 5.13.1 to 10.2.4

browserify-ngannotate      😎  MAJOR UP  Major update available: https://github.com/omsmith/browserify-ngannotate
                                        npm install --save-dev browserify-ngannotate@1.0.1 to go from 0.1.0 to 1.0.1

browserify-shim            😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save-dev browserify-shim to remove.

bulkify                    😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save-dev bulkify to remove.

del                        😎  MAJOR UP  Major update available: https://github.com/sindresorhus/del#readme
                                        npm install --save-dev del@1.2.0 to go from 0.1.3 to 1.2.0

gulp-sass                  😎  MAJOR UP  Major update available: https://github.com/dlmanning/gulp-sass
                                        npm install --save-dev gulp-sass@2.0.1 to go from 1.3.3 to 2.0.1

gulp-gzip                  😎  MAJOR UP  Major update available: https://github.com/jstuckey/gulp-gzip/
                                        npm install --save-dev gulp-gzip@1.1.0 to go from 0.0.8 to 1.1.0

gulp-protractor            😎  MAJOR UP  Major update available: https://github.com/mllrsohn/gulp-protractor
                                        npm install --save-dev gulp-protractor@1.0.0 to go from 0.0.11 to 1.0.0

gulp-imagemin              😎  MAJOR UP  Major update available: https://github.com/sindresorhus/gulp-imagemin
                                        npm install --save-dev gulp-imagemin@2.2.1 to go from 1.2.1 to 2.2.1

protractor                 😎  MAJOR UP  Major update available: https://github.com/angular/protractor
                                        npm install --save-dev protractor@2.1.0 to go from 1.8.0 to 2.1.0

imagemin-pngcrush          😎  MAJOR UP  Major update available: https://github.com/imagemin/imagemin-pngcrush
                                        npm install --save-dev imagemin-pngcrush@4.1.0 to go from 0.1.0 to 4.1.0
                           😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save-dev imagemin-pngcrush to remove.

run-sequence               😎  MAJOR UP  Major update available: https://github.com/OverZealous/run-sequence
                                        npm install --save-dev run-sequence@1.1.0 to go from 0.3.7 to 1.1.0

jshint-stylish             😎  MAJOR UP  Major update available: https://github.com/sindresorhus/jshint-stylish
                                        npm install --save-dev jshint-stylish@2.0.0 to go from 1.0.2 to 2.0.0
                           😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save-dev jshint-stylish to remove.

morgan                     💩  UPDATE!   Your local install is out of date.
                                        npm install morgan to go from 1.5.3 to 1.6.0

photoswipe                 😎  PATCH UP  Patch update available: http://photoswipe.com
                                        npm install --save-dev photoswipe@4.0.8 to go from 4.0.7 to 4.0.8

pretty-hrtime              😎  MAJOR UP  Major update available: https://github.com/robrich/pretty-hrtime
                                        npm install --save-dev pretty-hrtime@1.0.0 to go from 0.2.2 to 1.0.0

tiny-lr                    😎  NEW VER!  NonSemver update available: https://github.com/mklabs/tiny-lr
                                        npm install --save-dev tiny-lr@0.1.6 to go from 0.0.9 to 0.1.6

uglifyify                  😎  MAJOR UP  Major update available: https://github.com/hughsk/uglifyify
                                        npm install --save-dev uglifyify@3.0.1 to go from 2.6.0 to 3.0.1
                           😕  NOTUSED?  Possibly never referenced in the code.
                                        npm uninstall --save-dev uglifyify to remove.

vinyl-source-stream        😎  MAJOR UP  Major update available: https://github.com/hughsk/vinyl-source-stream
                                        npm install --save-dev vinyl-source-stream@1.1.0 to go from 0.1.1 to 1.1.0

watchify                   😎  MAJOR UP  Major update available: https://github.com/substack/watchify
                                        npm install --save-dev watchify@3.2.2 to go from 2.6.2 to 3.2.2
aneeshd16 commented 9 years ago

I would not recommend updating packages as it can totally break our setup. We would need to update and test each package one by one to see if the setup still works.

sudheesh001 commented 9 years ago

@aneeshd16 I would say, lets not update at all but lets focus on removing the ones NOT USED

aneeshd16 commented 9 years ago

Alright, but since this is not causing any issues/problems now, I would give this low priority. Let this issue remain open, we can do this later. How about changing the milestone for this?

aneeshd16 commented 9 years ago

Related #180