search

fossasia / loklak_webclient

loklak web application
http://loklak-web.herokuapp.com
MIT License
1.56k stars 49 forks source link

Fixes issue #536 #573

Closed sopankhosla closed 8 years ago

sopankhosla commented 8 years ago

screenshot from 2016-03-07 13 00 10

aneeshd16 commented 8 years ago

@sopu What happens if you click that marker when it is right at the top of the map?

sopankhosla commented 8 years ago

@aneeshd16 The map shifts downwards to accommodate the pop-up

aneeshd16 commented 8 years ago

Alright great! Will test and merge.

sopankhosla commented 8 years ago

@aneeshd16 Suggestions?

sudheesh001 commented 8 years ago

@sopu Is there a specific reason behind the CSS change rather than using the panTo functionality ?

http://leafletjs.com/reference.html#map-panto

sopankhosla commented 8 years ago

@sudheesh001 Yeah actually a small change here (adding something) could do the trick. I will check when the services resume.

mariobehling commented 8 years ago

@sopu What is the status of this PR? Can it be used and merged?

sudheesh001 commented 8 years ago

I am not sure this is the right way to do this patch, as mentioned we need to go with PanTo() and make the pan to the center. I am closing this since it's old and we can work on a newer patch for this. 😄