search

fossasia / meilix-artwork

Meilix Artwork
GNU General Public License v3.0
1.44k stars 18 forks source link

add a new bootscreen theme #72

Closed ammarbinfaisal1 closed 5 years ago

ammarbinfaisal1 commented 5 years ago

Checklist

Changes proposed in this pull request:

bootscreen

view it in properly Thank you!

tabesin commented 5 years ago

Why does your pr include changes to meilix-logo? Meilix-logo2 should be completely self-sustained, no?

ammarbinfaisal1 commented 5 years ago

So, should there be a different deb package named plymouth-theme-melix-logo2 ?

On Mon, 26 Nov 2018 4:21 pm tabesin, notifications@github.com wrote:

Why does your pr include changes to meilix-logo? Meilix-logo2 should be completely self-sustained, no?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/meilix-artwork/pull/72#issuecomment-441597647, or mute the thread https://github.com/notifications/unsubscribe-auth/AdimfnEuSqipz0pFQu4iW7_j9iQDyYPVks5uy8fGgaJpZM4Yxyzq .

ammarbinfaisal1 commented 5 years ago

made a separate package. any mistakes there?

bootscreen I made circles also use the color meilix logo's wavy circular lines are using - the light red one. is this better? or should I use te dark one only.

ammarbinfaisal1 commented 5 years ago

i think dark circles looks better, so i have made them dark again

bootscreen2

ammarbinfaisal1 commented 5 years ago

@pranav1698 done

ammarbinfaisal1 commented 5 years ago

dnt know, it was generated somehow. should I remove it?

tabesin commented 5 years ago

You could also rename logo2 to plymouth-theme-meilix-ammar ;)

The idea is that we have three themes in the end. And the ammar theme package would be the default.

Let's me once more check it. I think however it could be merged in the current stage and then further improved. An issue like this should not stay a pending PR for too long...